This repository was archived by the owner on Apr 23, 2021. It is now read-only.
Avoid trouble with shutting down HTTPClient #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
usecase/end-to-end
branch
from
f4803f7 to
9988a3a
Compare
ktoso
force-pushed
the
usecase/end-to-end
branch
from
9988a3a to
c20ae2a
Compare
ktoso
commented
Jun 22, 2020
| @@ -6,21 +6,36 @@ import NIO | |||
| import NIOHTTP1 | |||
|
|
|||
| struct InstrumentedHTTPClient { | |||
| private let client = HTTPClient(eventLoopGroupProvider: .createNew) | |||
There was a problem hiding this comment.
we were ignoring the init's passed in value here; so fixed this
ktoso
commented
Jun 22, 2020
ktoso
commented
Jun 22, 2020
ktoso
commented
Jun 22, 2020
ktoso
commented
Jun 22, 2020
ktoso
commented
Jun 22, 2020
| @@ -9,15 +9,15 @@ import NIOHTTP1 | |||
| import NIO | |||
|
|
|||
| let eventLoopGroup = MultiThreadedEventLoopGroup(numberOfThreads: System.coreCount) | |||
| let threadPool = NIOThreadPool(numberOfThreads: 6) | |||
| threadPool.start() | |||
There was a problem hiding this comment.
i don't think we'll need one?
ktoso
commented
Jun 22, 2020
| @@ -57,8 +56,9 @@ httpClient.get(url: "http://localhost:8080").whenComplete { result in | |||
| sleep(20) | |||
|
|
|||
| try httpClient.syncShutdown() | |||
| try orderServiceChannel.close().wait() | |||
| try storageServiceChannel.close().wait() | |||
There was a problem hiding this comment.
I guess we don't really have to right now since we kill the EL, but this would be a good way if we had any cleanup to do in channelRemoved -- but we don't... So consider this optional here I guess
slashmo
approved these changes
Jun 22, 2020
| @@ -6,21 +6,36 @@ import NIO | |||
| import NIOHTTP1 | |||
|
|
|||
| struct InstrumentedHTTPClient { | |||
| private let client = HTTPClient(eventLoopGroupProvider: .createNew) | |||
|
|
||
| let orderServiceBootstrap = ServerBootstrap(group: eventLoopGroup) | ||
| .serverChannelOption(ChannelOptions.backlog, value: 256) | ||
| .serverChannelOption(ChannelOptions.socketOption(.so_reuseaddr), value: 1) | ||
| .childChannelInitializer { channel in | ||
| channel.pipeline.configureHTTPServerPipeline().flatMap { | ||
| channel.pipeline.addHandler(OrderServiceHandler(instrument: FakeTracer())) | ||
| channel.pipeline.addHandler(OrderServiceHandler(httpClient: httpClient, instrument: FakeTracer())) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.